linux-kernel - Re: Performance regression introduced by commit b667b8673443 ("pipe: Advance tail pointer inside of wait spinlock in pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b70a0334-63be-b3a5-6f8a-714fbe4637c7@redhat.com>
Date:   Fri, 17 Jan 2020 13:11:07 -0500
From:   Waiman Long <longman@...hat.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     David Howells <dhowells@...hat.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: Performance regression introduced by commit b667b8673443 ("pipe:
 Advance tail pointer inside of wait spinlock in pipe_read()")

On 1/17/20 12:29 PM, Waiman Long wrote:
> On 1/17/20 12:05 PM, Linus Torvalds wrote:
>> [ on mobile, sorry for html crud ]
>>
>> On Fri, Jan 17, 2020, 08:53 Waiman Long <longman@...hat.com
>> <mailto:longman@...hat.com>> wrote:
>>
>>
>>     I had found that parallel kernel build became much slower when a
>>     5.5-based kernel is used. On a 2-socket 96-thread x86-64 system, the
>>     "make -j88" time increased from less than 3 minutes with the 5.4
>>     kernel
>>     to more than double with the 5.5 kernel.
>>
>>
>> I suspect you may have hit the same bug in the GNU make jobserver
>> that I did.
>>
>> It's timing-sensitive, and under the right circumstances the make
>> jobserver loses job tickets to other jobservers that have a child
>> that died, but they are blocked waiting for a new ticket, so they
>> aren't releasing (or re-using) the one that the child death would
>> free up.
>>
>> End result: a big lack of parallelism, and a much slower build.
>>
>> GNU make v4.2.1 is buggy. The fix was done over two years ago, but
>> there hasn't been a new release since then, so a lot of distributions
>> have the buggy version..
>>
>> The fix is commit b552b05 ("[SV 51159] Use a non-blocking read with
>> pselect to avoid hangs.") In the make the git tree.
>>
>>
>>      Linus
>
> Thanks for the information.
>
> Yes, I did use make v4.2.1 which is the version that is shipped in
> RHEL8. I will build new make and try it.
>
> Thanks,
> Longman
>
I built a make with the lastest make git tree and the problem was gone
with the new make. So it was a bug in make not the kernel. Sorry for the
noise.

Cheers,
Longman