linux-kernel - Re: [PATCH v9 2/2] EDAC: add EDAC driver for DMC520

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d05f6394-e076-6c99-965a-28444c0f24f9@gmail.com>
Date:   Fri, 17 Jan 2020 10:24:10 -0800
From:   Shiping Ji <shiping.linux@...il.com>
To:     Scott Branden <scott.branden@...adcom.com>,
        Borislav Petkov <bp@...en8.de>,
        James Morse <james.morse@....com>, robh+dt@...nel.org,
        mark.rutland@....com
Cc:     devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-edac@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        sashal@...nel.org, hangl@...rosoft.com,
        Lei Wang <lewan@...rosoft.com>, shji@...rosoft.com,
        ruizhao@...rosoft.com, Yuqing Shen <yuqing.shen@...adcom.com>,
        ray.jui@...adcom.com, wangglei@...il.com
Subject: Re: [PATCH v9 2/2] EDAC: add EDAC driver for DMC520

On 1/16/2020 4:31 PM, Scott Branden wrote:
> Hi Shiping,
> 
> Here is another small change to cleanup.
>> +    } else {
>> +        memset(info, 0, sizeof(struct ecc_error_info));
> This should be sizeof(*info), not sizeof(struct ecc_error_info)
> for better programming to allow info to change type in the future
> without the code changing.

Yes, two occurrences will be replaced in the next patch, thanks!

-- 
Best regards,
Shiping Ji