linux-kernel - Re: [PATCH v9 2/2] EDAC: add EDAC driver for DMC520

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200117185728.GC31472@zn.tnic>
Date:   Fri, 17 Jan 2020 19:57:28 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Shiping Ji <shiping.linux@...il.com>
Cc:     James Morse <james.morse@....com>, robh+dt@...nel.org,
        mark.rutland@....com, devicetree@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, linux-edac@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        sashal@...nel.org, hangl@...rosoft.com,
        Lei Wang <lewan@...rosoft.com>, shji@...rosoft.com,
        ruizhao@...rosoft.com, Scott Branden <scott.branden@...adcom.com>,
        Yuqing Shen <yuqing.shen@...adcom.com>, ray.jui@...adcom.com,
        wangglei@...il.com
Subject: Re: [PATCH v9 2/2] EDAC: add EDAC driver for DMC520

On Fri, Jan 17, 2020 at 10:31:18AM -0800, Shiping Ji wrote:
> This is to protect concurrent writes to the mci->error_desc as
> suggested by James when reviewing the patch v3.

Please comment that in the structure definition so that it is clear what
it is for.

> I'm trying to find a good scheme to make them shorter, at the moment
> they are named according to the TRM.

Yeah, keeping it the same as the documentation is also a good idea. I
leave it up to you to decide as you'll be staring at that code when bugs
happen. :)

> I'm not sure how this can be done perfectly with tabs only :)

Who says you should use only tabs? :-)

> All other comments have been addressed in the next patch, many thanks!

Thanks too.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette