linux-kernel - Re: [PATCH 1/1] Return EINVAL when precise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202001182239.IJMl4SVW%lkp@intel.com>
Date:   Sat, 18 Jan 2020 22:11:56 +0800
From:   kbuild test robot <lkp@...el.com>
To:     James Clark <james.clark@....com>
Cc:     kbuild-all@...ts.01.org, linux-arm-kernel@...ts.infradead.org,
        nd@....com, James Clark <james.clark@....com>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Tan Xiaojun <tanxiaojun@...wei.com>,
        Al Grant <al.grant@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Return EINVAL when precise_ip perf events are
 requested on Arm

Hi James,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm-soc/for-next]
[also build test ERROR on tip/perf/core linux/master linus/master v5.5-rc6 next-20200117]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/James-Clark/Return-EINVAL-when-precise_ip-perf-events-are-requested-on-Arm/20200116-195500
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers//perf/arm_pmu.c: In function 'armpmu_map_event':
>> drivers//perf/arm_pmu.c:105:18: error: 'struct perf_event_attr' has no member named 'precise'; did you mean 'precise_ip'?
     if (event->attr.precise)
                     ^~~~~~~
                     precise_ip

vim +105 drivers//perf/arm_pmu.c

    92	
    93	int
    94	armpmu_map_event(struct perf_event *event,
    95			 const unsigned (*event_map)[PERF_COUNT_HW_MAX],
    96			 const unsigned (*cache_map)
    97					[PERF_COUNT_HW_CACHE_MAX]
    98					[PERF_COUNT_HW_CACHE_OP_MAX]
    99					[PERF_COUNT_HW_CACHE_RESULT_MAX],
   100			 u32 raw_event_mask)
   101	{
   102		u64 config = event->attr.config;
   103		int type = event->attr.type;
   104	
 > 105		if (event->attr.precise)
   106			return -EINVAL;
   107	
   108		if (type == event->pmu->type)
   109			return armpmu_map_raw_event(raw_event_mask, config);
   110	
   111		switch (type) {
   112		case PERF_TYPE_HARDWARE:
   113			return armpmu_map_hw_event(event_map, config);
   114		case PERF_TYPE_HW_CACHE:
   115			return armpmu_map_cache_event(cache_map, config);
   116		case PERF_TYPE_RAW:
   117			return armpmu_map_raw_event(raw_event_mask, config);
   118		}
   119	
   120		return -ENOENT;
   121	}
   122	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (72712 bytes)