linux-kernel - Re: [PATCH v2] io_uring: optimise sqe-to-req flags translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad7c75c3-b660-9814-e3fe-ef5a3acd7e8f@gmail.com>
Date:   Sat, 18 Jan 2020 20:10:30 +0300
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Jens Axboe <axboe@...nel.dk>, io-uring@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] io_uring: optimise sqe-to-req flags translation

On 18/01/2020 19:34, Jens Axboe wrote:
>> +enum {
>> +	/* correspond one-to-one to IOSQE_IO_* flags*/
>> +	REQ_F_FIXED_FILE	= BIT(REQ_F_FIXED_FILE_BIT),	/* ctx owns file */
> 
> I'd put the comment on top of the line instead, these lines are way too
> long.

I find it less readable, but let's see

> 
> Let's please not use BIT() for the user visible part, though. And I'd
> leave these as defines, sometimes apps do things ala:
> 
> #ifndef IOSQE_IO_LINK
> #define IOSQE_IO_LINK ...
> #endif
> 
> to make it easier to co-exist with old and new headers.
>Yeah, good point!

-- 
Pavel Begunkov



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)