linux-kernel - [PATCH] arch/x86/kernel/tsc_sync.c: Clean up code by removing unused assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200118171143.25178-1-mateusznosek0@gmail.com>
Date:   Sat, 18 Jan 2020 18:11:43 +0100
From:   mateusznosek0@...il.com
To:     linux-kernel@...r.kernel.org
Cc:     Mateusz Nosek <mateusznosek0@...il.com>, x86@...nel.org,
        hpa@...or.com, bp@...en8.de, mingo@...hat.com, tglx@...utronix.de
Subject: [PATCH] arch/x86/kernel/tsc_sync.c: Clean up code by removing unused assignment

From: Mateusz Nosek <mateusznosek0@...il.com>

Previously the assignment to local variable 'now' took place before the for
loop. The loop is unconditional so it will be entered at least once. The
variable 'now' is reassigned in the loop and is not used before reassigning.
Therefore the assignment before the loop is unnecessary and can be removed.

Signed-off-by: Mateusz Nosek <mateusznosek0@...il.com>
---
 arch/x86/kernel/tsc_sync.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/tsc_sync.c b/arch/x86/kernel/tsc_sync.c
index b8acf639abd1..32a818764e03 100644
--- a/arch/x86/kernel/tsc_sync.c
+++ b/arch/x86/kernel/tsc_sync.c
@@ -233,7 +233,6 @@ static cycles_t check_tsc_warp(unsigned int timeout)
 	 * The measurement runs for 'timeout' msecs:
 	 */
 	end = start + (cycles_t) tsc_khz * timeout;
-	now = start;
 
 	for (i = 0; ; i++) {
 		/*
-- 
2.17.1