linux-kernel - Re: [PATCH 4/4] GPIO: creg-snps: fixed a typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7010f3bc07d2666e6bbde3140d51acd539cb55b.camel@perches.com>
Date:   Sat, 18 Jan 2020 09:29:26 -0800
From:   Joe Perches <joe@...ches.com>
To:     sachin agarwal <asachin591@...il.com>, Eugeniy.Paltsev@...opsys.com
Cc:     linus.walleij@...aro.org, bgolaszewski@...libre.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] GPIO: creg-snps: fixed a typo

On Sat, 2020-01-18 at 16:15 +0530, sachin agarwal wrote:
> From: Sachin agarwal <asachin591@...il.com>
> 
> we had written "valiue" rather than "value".
[]
> diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
[]
> @@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
>  	if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
>  		return -EINVAL;
>  
> -	/* Check that on valiue fits it's placeholder */
> +	/* Check that on value fits it's placeholder */

Might as well fix the it's/its usages too.

>  	if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
>  		return -EINVAL;
> 
> -	/* Check that off valiue fits it's placeholder */
> +	/* Check that off value fits it's placeholder */
>  	if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
>  		return -EINVAL;
>