linux-kernel - Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200119125229.GA149325@kroah.com>
Date:   Sun, 19 Jan 2020 13:52:29 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Simon Fong <simon.fongnt@...il.com>
Cc:     abbotti@....co.uk, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, colin.king@...onical.com
Subject: Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align
 it

On Sun, Jan 19, 2020 at 01:50:24PM +0100, Greg KH wrote:
> On Sun, Jan 19, 2020 at 11:52:43AM +0800, Simon Fong wrote:
> > Clean up long line and align it
> > 
> > Signed-off-by: Simon Fong <simon.fongnt@...il.com>
> > ---
> >  drivers/staging/comedi/drivers/usbdux.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> > index 0350f303d557..b9c0b1a1d86e 100644
> > --- a/drivers/staging/comedi/drivers/usbdux.c
> > +++ b/drivers/staging/comedi/drivers/usbdux.c
> > @@ -204,7 +204,8 @@ struct usbdux_private {
> >  	struct mutex mut;
> >  };
> >  
> > -static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)
> > +static void usbdux_unlink_urbs(struct urb **urbs,
> > +			       int num_urbs)
> 
> As Joe said, there is no reason to change this line that I can see, why
> do you want to do that?

Also, where are patches 1 and 2 of this 3 patch series?

thanks,

greg k-h