linux-kernel - Re: [PATCH, v5.4] perf: Correctly handle failed perf_get_aux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Jan 2020 14:28:11 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Vince Weaver <vincent.weaver@...ne.edu>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        stable kernel team <stable@...r.kernel.org>
Subject: Re: [PATCH, v5.4] perf: Correctly handle failed perf_get_aux_event()

On Sat, Jan 18, 2020 at 07:05:29PM +0100, Ingo Molnar wrote:
> 
> * Vince Weaver <vincent.weaver@...ne.edu> wrote:
> 
> > On Mon, 6 Jan 2020, Vince Weaver wrote:
> > 
> > > On Mon, 6 Jan 2020, Mark Rutland wrote:
> > > 
> > > > On Thu, Jan 02, 2020 at 02:22:47PM -0500, Vince Weaver wrote:
> > > > > On Thu, 2 Jan 2020, Vince Weaver wrote:
> > > > > 
> > > > Vince, does the below (untested) patch work for you?
> > > 
> > > 
> > > yes, this patch fixes things for me.
> > > 
> > > Tested-by: Vince Weaver <vincent.weaver@...ne.edu>
> > > 
> > 
> > is this patch going to make it upstream?  It's a fairly major correctness 
> > bug with perf_event_open().
> 
> I just sent it to Linus.
> 
> In hindsight this should have been marked Cc: stable for v5.4 - we should 
> forward it to Greg once Linus has pulled it:
> 
>    da9ec3d3dd0f: ("perf: Correctly handle failed perf_get_aux_event()")
> 
> 
> Note that in the v5.4 cherry-pick there's a conflict due to interaction 
> with another recent commit - I've attached the ported fix against v5.4, 
> but have only test built it.

Thanks for the backport, now queued up.

greg k-h