linux-kernel - Re: [PATCH] ARM: decompressor: simplify libfdt builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Jan 2020 10:24:01 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: decompressor: simplify libfdt builds

Hi Russell,

On Sat, Jan 18, 2020 at 7:15 AM Russell King - ARM Linux admin
<linux@...linux.org.uk> wrote:
> > -ifeq ($(CONFIG_ARM_ATAG_DTB_COMPAT),y)
> > -OBJS += $(libfdt_objs) atags_to_fdt.o
> > +# -fstack-protector-strong triggers protection checks in this code,
> > +# but it is being used too early to link to meaningful stack_chk logic.
> > +nossp-flags-$(CONFIG_CC_HAS_STACKPROTECTOR_NONE) := -fno-stack-protector
> > +$(foreach o, $(libfdt_objs), \
> > +     $(eval CFLAGS_$(o) := -I $(srctree)/scripts/dtc/libfdt) $(nossp-flags-y))
>
> The above change causes build breakage over a number of ARM builds,
> which unfortunately doesn't result in emails from any build system
> containing the cause of the failure.
>
> See
> https://kernelci.org/build/rmk/branch/for-next/kernel/v5.5-rc1-12-g9a6545e2fc83/
>
> where the failures are reported as:
>
> ../arch/arm/boot/compressed/Makefile:87: *** missing separator. Stop.
>
> Thanks.  Patch dropped.


Sorry, I made a mistake about the location of
the closing parenthesis.


I fixed the build error, and posted v2:

https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8953/1





-- 
Best Regards
Masahiro Yamada