linux-kernel - Re: [PATCH] KVM: arm/arm64: vgic: Drop the kvm_vgic_register_mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Jan 2020 09:47:57 +1100
From:   Gavin Shan <gshan@...hat.com>
To:     Zenghui Yu <yuzenghui@...wei.com>, maz@...nel.org
Cc:     Haibin Wang <wanghaibin.wang@...wei.com>,
        kvmarm@...ts.cs.columbia.edu, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: arm/arm64: vgic: Drop the
 kvm_vgic_register_mmio_region()

On 1/19/20 8:06 PM, Zenghui Yu wrote:
> kvm_vgic_register_mmio_region() was introduced in commit 4493b1c4866a
> ("KVM: arm/arm64: vgic-new: Add MMIO handling framework") but never
> used, and even never implemented. Remove it to avoid confusing readers.
> 
> Reported-by: Haibin Wang <wanghaibin.wang@...wei.com>
> Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>
> ---

Reviewed-by: Gavin Shan <gshan@...hat.com>

>   virt/kvm/arm/vgic/vgic-mmio.h | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/virt/kvm/arm/vgic/vgic-mmio.h b/virt/kvm/arm/vgic/vgic-mmio.h
> index 836f418f1ee8..5af2aefad435 100644
> --- a/virt/kvm/arm/vgic/vgic-mmio.h
> +++ b/virt/kvm/arm/vgic/vgic-mmio.h
> @@ -98,11 +98,6 @@ extern struct kvm_io_device_ops kvm_io_gic_ops;
>   		.uaccess_write = uwr,					\
>   	}
>   
> -int kvm_vgic_register_mmio_region(struct kvm *kvm, struct kvm_vcpu *vcpu,
> -				  struct vgic_register_region *reg_desc,
> -				  struct vgic_io_device *region,
> -				  int nr_irqs, bool offset_private);
> -
>   unsigned long vgic_data_mmio_bus_to_host(const void *val, unsigned int len);
>   
>   void vgic_data_host_to_mmio_bus(void *buf, unsigned int len,
>