linux-kernel - RE: [PATCH] Drivers: hv: vmbus: Ignore CHANNELMSG_TL_CONNECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Jan 2020 23:35:32 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Michael Kelley <mikelley@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "sashal@...nel.org" <sashal@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sasha Levin <Alexander.Levin@...rosoft.com>
CC:     Sunil Muthuswamy <sunilmut@...rosoft.com>,
        Andrea Parri <Andrea.Parri@...rosoft.com>
Subject: RE: [PATCH] Drivers: hv: vmbus: Ignore
 CHANNELMSG_TL_CONNECT_RESULT(23)

> From: Michael Kelley
> Sent: Saturday, January 18, 2020 9:29 AM
> > +
> > +	/* Linux ignores some messages, e.g.
> CHANNELMSG_TL_CONNECT_RESULT. */
> > +	if (!entry->message_handler)
> > +		goto msg_handled;
> > +
> 
> FWIW, with this new check, all of the validity checks in vmbus_onmessage()
> are redundant and could be removed.  There's already a check here that
> ensures msgtype won't be too big, and this new check ensures that 
> message_handler is not NULL.

Agreed. I just sent a v2 that removes the redundant code.

> >  	if (entry->handler_type	== VMHT_BLOCKING) {
> >  		ctx = kmalloc(sizeof(*ctx), GFP_ATOMIC);
> >  		if (ctx == NULL)
> > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> > index 26f3aeeae1ca..41c58011431e 100644
> > --- a/include/linux/hyperv.h
> > +++ b/include/linux/hyperv.h
> > @@ -425,6 +425,8 @@ enum vmbus_channel_message_type {
> >  	CHANNELMSG_19				= 19,
> >  	CHANNELMSG_20				= 20,
> >  	CHANNELMSG_TL_CONNECT_REQUEST		= 21,
> > +	CHANNELMSG_22				= 22,
> > +	CHANNELMSG_TL_CONNECT_RESULT		= 23,
> >  	CHANNELMSG_COUNT
> >  };
> 
> For completeness, I'd like to see the channel_message_table also updated
> with these new entries so that everything stays in sync and is explicitly
> defined.
> 
> Michael

I fixed this in v2 as well.

Thanks!
Dexuan