linux-kernel - Re: [PATCH v12 4/4] watchdog: mtk_wdt: mt2712: Add reset controller

Open Source and information security mailing list archives

Message-ID: <1579404112.27500.0.camel@mhfsdcap03>
Date:   Sun, 19 Jan 2020 11:21:52 +0800
From:   Yong Liang <yong.liang@...iatek.com>
To:     Matthias Brugger <matthias.bgg@...il.com>
CC:     "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Chang-An Chen (陳昶安) 
        <Chang-An.Chen@...iatek.com>,
        Freddy Hsin (辛恒豐) 
        <Freddy.Hsin@...iatek.com>,
        Jiaxin Yu (俞家鑫) 
        <Jiaxin.Yu@...iatek.com>, "sboyd@...nel.org" <sboyd@...nel.org>,
        Yingjoe Chen (陳英洲) 
        <Yingjoe.Chen@...iatek.com>
Subject: Re: [PATCH v12 4/4] watchdog: mtk_wdt: mt2712: Add reset controller

On Thu, 2020-01-16 at 00:18 +0800, Matthias Brugger wrote:
> 
> On 15/01/2020 09:58, Yong Liang wrote:
> > From: "yong.liang" <yong.liang@...iatek.com>
> > 
> > Add reset controller for 2712.
> > Besides watchdog, MTK toprgu module alsa provide sub-system (eg, audio,
> > camera, codec and connectivity) software reset functionality.
> > 
> > Signed-off-by: yong.liang <yong.liang@...iatek.com>
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@...iatek.com>
> > Reviewed-by: Yingjoe Chen <yingjoe.chen@...iatek.com>
> > Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>
> 
> Acked-by: Matthias Brugger <matthias.bgg@...il.com>

Hi Mattias:
  May I need send a new patch whith this tag?
> 
> > ---
> >  drivers/watchdog/mtk_wdt.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> > index e88aacb0404d..d6a6393f609d 100644
> > --- a/drivers/watchdog/mtk_wdt.c
> > +++ b/drivers/watchdog/mtk_wdt.c
> > @@ -9,6 +9,7 @@
> >   * Based on sunxi_wdt.c
> >   */
> >  
> > +#include <dt-bindings/reset-controller/mt2712-resets.h>
> >  #include <dt-bindings/reset-controller/mt8183-resets.h>
> >  #include <linux/delay.h>
> >  #include <linux/err.h>
> > @@ -67,6 +68,10 @@ struct mtk_wdt_data {
> >  	int toprgu_sw_rst_num;
> >  };
> >  
> > +static const struct mtk_wdt_data mt2712_data = {
> > +	.toprgu_sw_rst_num = MT2712_TOPRGU_SW_RST_NUM,
> > +};
> > +
> >  static const struct mtk_wdt_data mt8183_data = {
> >  	.toprgu_sw_rst_num = MT8183_TOPRGU_SW_RST_NUM,
> >  };
> > @@ -314,6 +319,7 @@ static int mtk_wdt_resume(struct device *dev)
> >  #endif
> >  
> >  static const struct of_device_id mtk_wdt_dt_ids[] = {
> > +	{ .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data },
> >  	{ .compatible = "mediatek,mt6589-wdt" },
> >  	{ .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data },
> >  	{ /* sentinel */ }
> > 
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives