linux-kernel - Re: [RFC PATCH 2/4] drm/i915/gvt: remove unused vblank_done completion

Open Source and information security mailing list archives

Message-ID: <20200120062330.GB14597@zhen-hp.sh.intel.com>
Date:   Mon, 20 Jan 2020 14:23:30 +0800
From:   Zhenyu Wang <zhenyuw@...ux.intel.com>
To:     Julian Stecklina <julian.stecklina@...erus-technology.de>
Cc:     intel-gvt-dev@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Zhenyu Wang <zhenyuw@...ux.intel.com>, hang.yuan@...el.com,
        dri-devel@...ts.freedesktop.org, zhiyuan.lv@...el.com
Subject: Re: [RFC PATCH 2/4] drm/i915/gvt: remove unused vblank_done
 completion

On 2020.01.09 19:13:55 +0200, Julian Stecklina wrote:
> This variable is used nowhere, so remove it.
> 
> Cc: Zhenyu Wang <zhenyuw@...ux.intel.com>
> 
> Signed-off-by: Julian Stecklina <julian.stecklina@...erus-technology.de>
> ---

Thanks for catching this.

Acked-by: Zhenyu Wang <zhenyuw@...ux.intel.com>

>  drivers/gpu/drm/i915/gvt/gvt.h   | 2 --
>  drivers/gpu/drm/i915/gvt/kvmgt.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h
> index 2604739e5680..8cf292a8d6bd 100644
> --- a/drivers/gpu/drm/i915/gvt/gvt.h
> +++ b/drivers/gpu/drm/i915/gvt/gvt.h
> @@ -203,8 +203,6 @@ struct intel_vgpu {
>  	struct mutex dmabuf_lock;
>  	struct idr object_idr;
>  
> -	struct completion vblank_done;
> -
>  	u32 scan_nonprivbb;
>  };
>  
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index d725a4fb94b9..9a435bc1a2f0 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1817,8 +1817,6 @@ static int kvmgt_guest_init(struct mdev_device *mdev)
>  	kvmgt_protect_table_init(info);
>  	gvt_cache_init(vgpu);
>  
> -	init_completion(&vgpu->vblank_done);
> -
>  	info->track_node.track_write = kvmgt_page_track_write;
>  	info->track_node.track_flush_slot = kvmgt_page_track_flush_slot;
>  	kvm_page_track_register_notifier(kvm, &info->track_node);
> -- 
> 2.24.1
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives