lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jan 2020 08:02:20 +0000 From: Lee Jones <lee.jones@...aro.org> To: "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com> Cc: "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>, "dmurphy@...com" <dmurphy@...com>, "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "mturquette@...libre.com" <mturquette@...libre.com>, "mazziesaccount@...il.com" <mazziesaccount@...il.com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "jacek.anaszewski@...il.com" <jacek.anaszewski@...il.com>, "a.zummo@...ertech.it" <a.zummo@...ertech.it>, "linus.walleij@...aro.org" <linus.walleij@...aro.org>, "lgirdwood@...il.com" <lgirdwood@...il.com>, "mark.rutland@....com" <mark.rutland@....com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>, "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>, "sboyd@...nel.org" <sboyd@...nel.org>, "pavel@....cz" <pavel@....cz>, "broonie@...nel.org" <broonie@...nel.org> Subject: Re: [PATCH v10 11/13] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs On Mon, 20 Jan 2020, Vaittinen, Matti wrote: > Hello, > > On Fri, 2020-01-17 at 10:21 +0000, Lee Jones wrote: > > On Fri, 17 Jan 2020, Matti Vaittinen wrote: > > > > > ROHM BD71828 PMIC contains 4 pins which can be configured by OTP > > > to be used for general purposes. First 3 can be used as outputs > > > and 4.th pin can be used as input. Allow them to be controlled > > > via GPIO framework. > > > > > > The driver assumes all of the pins are configured as GPIOs and > > > trusts that the reserved pins in other OTP configurations are > > > excluded from control using "gpio-reserved-ranges" device tree > > > property (or left untouched by GPIO users). > > > > > > Typical use for 4.th pin (input) is to use it as HALL sensor > > > input so that this pin state is toggled when HALL sensor detects > > > LID position change (from close to open or open to close). PMIC > > > HW implements some extra logic which allows PMIC to power-up the > > > system when this pin is toggled. Please see the data sheet for > > > details of GPIO options which can be selected by OTP settings. > > > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com> > > > Reviewed-by: Bartosz Golaszewski <bgolaszewski@...libre.com> > > > Reviewed-by: Linus Walleij <linus.walleij@...aro.org> > > > > Linus, Is that an Ack? > I have always thought that reviewed-by implies that reviewer is Ok with > the patch (imples Ack). Maybe I have mistaken? I would rather not assume. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists