linux-kernel - Re: [RESEND 1/4] dt-bindings: regulator: Add document for MT6359 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Jan 2020 08:43:55 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Wen Su <Wen.Su@...iatek.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Mark Brown <broonie@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        devicetree@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-kernel@...ts.infradead.org, wsd_upstream@...iatek.com
Subject: Re: [RESEND 1/4] dt-bindings: regulator: Add document for MT6359
 regulator

On Mon, 20 Jan 2020, Wen Su wrote:

> From: Wen Su <wen.su@...iatek.com>
> 
> add dt-binding document for MediaTek MT6359 PMIC
> 
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Wen Su <wen.su@...iatek.com>

These are in the wrong order.  Tags should describe history, thus
should be in chronological order.  For instance, the ordering you used
describes Rob reviewing the patch *before* you sent it, which is not
possible.

> ---
>  .../bindings/regulator/mt6359-regulator.txt        | 59 ++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/mt6359-regulator.txt

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog