linux-kernel - Re: [PATCH] ARM: dts: bcm2711: Use bcm2711 compatible for sdhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Jan 2020 09:59:41 +0100
From:   Matthias Brugger <mbrugger@...e.com>
To:     Stephen Brennan <stephen@...nnan.io>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: bcm2711: Use bcm2711 compatible for sdhci



On 20/01/2020 05:17, Stephen Brennan wrote:
> When booting Raspberry Pi 4B using a micro SDHC UHS class 1 card, the SD
> card partitions never appear in /dev.  According to the device tree
> bindings for Broadcom IPROC SDHCI controller, we should use
> "brcm,bcm2711-emmc2" compatible string on BCM2711. Set this compatible
> string, which allows these cards to be mounted.
> 
> Signed-off-by: Stephen Brennan <stephen@...nnan.io>
> ---
>  arch/arm/boot/dts/bcm2711.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index b64865ad5a41..48e3b0162bda 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -853,6 +853,7 @@ &mailbox {
>  };
>  
>  &sdhci {
> +	compatible = "brcm,bcm2711-emmc2";
>  	interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>;
>  };
>  
> 

hm, sdhci is used to drive the wifi chip:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/bcm2711-rpi-4-b.dts?h=v5.5-rc7#n79

Are you sure you use the upstream devicetree?

Regards,
Matthias