linux-kernel - Re: [PATCH] tools/perf/metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200120092525.GB608405@krava>
Date:   Mon, 20 Jan 2020 10:25:25 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     kajoljain <kjain@...ux.ibm.com>
Cc:     "Jin, Yao" <yao.jin@...ux.intel.com>, acme@...nel.org,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>,
        Anju T Sudhakar <anju@...ux.vnet.ibm.com>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Subject: Re: [PATCH] tools/perf/metricgroup: Fix printing event names of
 metric group with multiple events incase of overlapping events

On Mon, Jan 20, 2020 at 10:23:56AM +0100, Jiri Olsa wrote:
> On Mon, Jan 20, 2020 at 02:23:19PM +0530, kajoljain wrote:
> > 
> > On 1/8/20 9:32 PM, Jiri Olsa wrote:
> > > On Wed, Jan 08, 2020 at 02:41:35PM +0530, kajoljain wrote:
> > > 
> > > SNIP
> > > 
> > > > > > -    int i = 0;
> > > > > > +    int i = 0, j = 0;
> > > > > >        bool leader_found;
> > > > > >          evlist__for_each_entry (perf_evlist, ev) {
> > > > > > +        j++;
> > > > > > +        if (j <= iterator_perf_evlist)
> > > > > > +            continue;
> > > > > >            if (!strcmp(ev->name, ids[i])) {
> > > > > >                if (!metric_events[i])
> > > > > >                    metric_events[i] = ev;
> > > > > > @@ -146,6 +151,7 @@ static struct evsel *find_evsel_group(struct
> > > > > > evlist *perf_evlist,
> > > > > >                }
> > > > > >            }
> > > > > >        }
> > > > > > +    iterator_perf_evlist = j;
> > > > > >          return metric_events[0];
> > > > > >    }
> > > > > > 
> > > > > Thanks for reporting and fixing this issue.
> > > > > 
> > > > > I just have one question, do we really need a *static variable* to track
> > > > > the matched events? Perhaps using an input parameter?
> > > > Hi Jin,
> > > > 
> > > > The other way I come up with to solve this issue is, making change in
> > > > perf_evlist itself by adding some flag in event name, to keep track of
> > > > matched events.
> > > > 
> > > > As if we change event name itself, next time when we compare it won't
> > > > matched. But in that case we need to remove those flag later. Which will
> > > > increase the
> > > > 
> > > > complexity. If you have any suggestions, please let me know.
> > > we already keep evsel::cpu_iter for similar concept
> > > 
> > > so I guess we could have some iterator_perf_evlist variable in evlist..
> > > that is if we don't find other solution (other than static varable)
> > 
> > Hi Jiri,
> > 
> >          Thanks for reviewing the patch. I checked 'evsel::cpu_iter'
> > variable, I think it added recently and I am not able to find any similar
> > kind of variable in
> > 
> >          evlist. Please let me know if my understanding is fine. Do you want
> > me to add new variable in evlist itself or there is any other way possible.

ah sry, it's in 'struct evsel' ;-)

jirka

> 
> please check Arnaldo's tree:
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core
> 
> jirka