linux-kernel - Re: [PATCH -mm] mm/page_isolation: fix potential warning from user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1a1e398-7f5b-3cb5-1c1b-41cf7d56486c@redhat.com>
Date:   Mon, 20 Jan 2020 10:42:52 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Michal Hocko <mhocko@...nel.org>,
        Anshuman Khandual <anshuman.khandual@....com>
Cc:     Qian Cai <cai@....pw>, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] mm/page_isolation: fix potential warning from user

>>> +	} else {
>>> +		if (isol_flags & MEMORY_OFFLINE)
>>> +			WARN_ON_ONCE(zone_idx(zone) == ZONE_MOVABLE);> +
>>> +		if ((isol_flags & REPORT_FAILURE) && !IS_ERR(unmovable))
>>> +			/*
>>> +			 * printk() with zone->lock held will likely trigger a
>>> +			 * lockdep splat, so defer it here.
>>> +			 */
>>> +			dump_page(unmovable, "unmovable page");
>>> +	}
>>> +
>>> +	return !!unmovable;
>>>  }
>>>  
>>>  static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
>>
>> set_migratetype_isolate() gets called from CMA as well as HugeTLB
>> allocation paths, so its not only during offline. Hence the commit
>> message should be changed to reflect this.
> 
> We should just report for all those cases I believe.
> 

+1

-- 
Thanks,

David / dhildenb