lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jan 2020 12:25:42 +0100 From: Ulf Hansson <ulf.hansson@...aro.org> To: YueHaibing <yuehaibing@...wei.com> Cc: Adrian Hunter <adrian.hunter@...el.com>, Takao Orito <orito.takao@...ionext.com>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH -next] mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message On Thu, 16 Jan 2020 at 15:43, YueHaibing <yuehaibing@...wei.com> wrote: > > platform_get_irq() will call dev_err() itself on failure, > so there is no need for the driver to also do this. > This is detected by coccinelle. > > Signed-off-by: YueHaibing <yuehaibing@...wei.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-milbeaut.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c > index e6245b7..92f30a1 100644 > --- a/drivers/mmc/host/sdhci-milbeaut.c > +++ b/drivers/mmc/host/sdhci-milbeaut.c > @@ -246,10 +246,8 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev) > struct f_sdhost_priv *priv; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "%s: no irq specified\n", __func__); > + if (irq < 0) > return irq; > - } > > host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv)); > if (IS_ERR(host)) > -- > 2.7.4 > >
Powered by blists - more mailing lists