linux-kernel - Re: [PATCH] pwm: remove set but not set variable 'pwm'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55871ad5-4cb0-f3c8-a408-2c1be894126a@huawei.com>
Date:   Mon, 20 Jan 2020 19:40:37 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
CC:     <thierry.reding@...il.com>, <linux-pwm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <zhengbin13@...wei.com>,
        <yi.zhang@...wei.com>
Subject: Re: [PATCH] pwm: remove set but not set variable 'pwm'

On 2020/1/20 15:34, Uwe Kleine-König wrote:
> Fixes: e926b12c611c ("pwm: Clear chip_data in pwm_put()")

Thank you for your advise! I'll add 'Fixes' in a V2 patch.

> Did you check that dropping the locking is save? (I didn't)
> 
> I'd assume that no harm is introduced, but mentioning that in the commit
> log would be good.

I think dropping the lock is safe since there is nothing to be done
inside the lock. However, I didn't run a full test. By the way, I'll
mentioning it in a V2 patch.

Thanks!
Yu Kuai