linux-kernel - Re: [PATCH v4 2/2] pwm: mtk_disp: keep the trigger register after pwm setting.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200120115404.GB206171@ulmo>
Date:   Mon, 20 Jan 2020 12:54:04 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Jitao Shi <jitao.shi@...iatek.com>
Cc:     Uwe Kleine-Koenig <u.kleine-koenig@...gutronix.de>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-pwm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, CK Hu <ck.hu@...iatek.com>,
        linux-mediatek@...ts.infradead.org, sj.huang@...iatek.com
Subject: Re: [PATCH v4 2/2] pwm: mtk_disp: keep the trigger register after
 pwm setting.

On Tue, Dec 17, 2019 at 12:02:37PM +0800, Jitao Shi wrote:
> Move the trigger after pwm setting to avoid the pwm wrong signal
> output.
> 
> Remove the regist enable trigger setting in probe.
> Move the trigger to end of mtk_disp_pwm_config().
> 
> Signed-off-by: Jitao Shi <jitao.shi@...iatek.com>
> ---
>  drivers/pwm/pwm-mtk-disp.c | 20 +++++++-------------
>  1 file changed, 7 insertions(+), 13 deletions(-)

Same as for patch 1/2, please make the commit message more useful. Don't
say what you do (because the patch already shows that), but instead say
why you do it, what the specific problems are that you're fixing, etc.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)