linux-kernel - Re: [PATCH] regulator: vctrl-regulator: Avoid deadlock getting and setting the voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Jan 2020 13:10:18 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Mark Brown <broonie@...nel.org>, Dmitry Osipenko <digetx@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Collabora Kernel ML <kernel@...labora.com>,
        drinkcat@...omium.org, dianders@...omium.org,
        Liam Girdwood <lgirdwood@...il.com>, mka@...omium.org
Subject: Re: [PATCH] regulator: vctrl-regulator: Avoid deadlock getting and
 setting the voltage



On 20/1/20 13:08, Mark Brown wrote:
> On Fri, Jan 17, 2020 at 07:28:04PM +0300, Dmitry Osipenko wrote:
>> 16.01.2020 12:45, Enric Balletbo i Serra пишет:
> 
>>> +EXPORT_SYMBOL(regulator_set_voltage_rdev);
>>>  
>>>  static int regulator_limit_voltage_step(struct regulator_dev *rdev,
>>>  					int *current_uV, int *min_uV)
>>> @@ -4034,6 +4035,7 @@ int regulator_get_voltage_rdev(struct regulator_dev *rdev)
>>>  		return ret;
>>>  	return ret - rdev->constraints->uV_offset;
>>>  }
>>> +EXPORT_SYMBOL(regulator_get_voltage_rdev);
> 
>> I think it should be EXPORT_SYMBOL_GPL().
> 
> Yes, you're right.
> 

Oops, right, Mark do you want me to send a follow-up patch, a second version or
you can just apply a fix?

Thanks,
 Enric