linux-kernel - Re: [PATCH v3 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <432ff907-044d-3e7c-75fc-0a172d1ed6c1@roeck-us.net>
Date:   Mon, 20 Jan 2020 06:25:00 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Thomas Hebb <tommyhebb@...il.com>, linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v3 1/2] usb: typec: wcove: fix "op-sink-microwatt" default
 that was in mW

On 1/20/20 6:09 AM, Thomas Hebb wrote:
> commit 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
> didn't convert this value from mW to uW when migrating to a new
> specification format like it should have.
> 
> Fixes: 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
> Cc: stable@...r.kernel.org
> Signed-off-by: Thomas Hebb <tommyhebb@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> 
> ---
> 
> Changes in v3:
> - Use the right stable email address
> 
> Changes in v2:
> - Split fix into two patches
> - Added stable cc
> 
>   drivers/usb/typec/tcpm/wcove.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/wcove.c b/drivers/usb/typec/tcpm/wcove.c
> index edc271da14f4..9b745f432c91 100644
> --- a/drivers/usb/typec/tcpm/wcove.c
> +++ b/drivers/usb/typec/tcpm/wcove.c
> @@ -597,7 +597,7 @@ static const struct property_entry wcove_props[] = {
>   	PROPERTY_ENTRY_STRING("try-power-role", "sink"),
>   	PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
>   	PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
> -	PROPERTY_ENTRY_U32("op-sink-microwatt", 15000),
> +	PROPERTY_ENTRY_U32("op-sink-microwatt", 15000000),
>   	{ }
>   };
>   
>