linux-kernel - Re: [PATCH] kernel/events: Add a missing prototype for arch_perf_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Jan 2020 16:31:25 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Benjamin Thiel <b.thiel@...teo.de>
Cc:     X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/events: Add a missing prototype for
 arch_perf_update_userpage()

On Thu, Jan 09, 2020 at 02:13:51PM +0100, Benjamin Thiel wrote:
> ... in order to fix a -Wmissing-prototype warning.
> 
> No functional changes.
> 
> Signed-off-by: Benjamin Thiel <b.thiel@...teo.de>
> ---
>  include/linux/perf_event.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 6d4c22aee384..de3874271814 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -1544,4 +1544,7 @@ int perf_event_exit_cpu(unsigned int cpu);
>  #define perf_event_exit_cpu	NULL
>  #endif
>  
> +void __weak arch_perf_update_userpage(
> +	struct perf_event *event, struct perf_event_mmap_page *userpg, u64 now);
> +

Indeed so, I've slightly changed to:

+extern void __weak arch_perf_update_userpage(struct perf_event *event,
+                                            struct perf_event_mmap_page *userpg,
+                                            u64 now);

Thanks!