| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <ba21d2c8-ccc6-2704-fa1f-d28239700547@lechnology.com>
Date: Mon, 20 Jan 2020 10:00:49 -0600
From: David Lechner <david@...hnology.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
Noralf Trønnes <noralf@...nnes.org>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>
Cc: Sam Ravnborg <sam@...nborg.org>,
Chris Brandt <chris.brandt@...esas.com>,
Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: Convert to
DT schema
On 1/15/20 6:45 AM, Geert Uytterhoeven wrote:
> Convert the DT binding documentation for Sitronix ST7735R displays to DT
> schema.
>
> Add a reference to the Adafruit 1.8" LCD while at it.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> v2:
> - New.
> ---
> .../bindings/display/sitronix,st7735r.txt | 35 ----------
> .../bindings/display/sitronix,st7735r.yaml | 65 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 66 insertions(+), 36 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> create mode 100644 Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> deleted file mode 100644
> index cd5c7186890a2be7..0000000000000000
> --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -Sitronix ST7735R display panels
> -
> -This binding is for display panels using a Sitronix ST7735R controller in SPI
> -mode.
> -
> -Required properties:
> -- compatible: "jianda,jd-t18003-t01", "sitronix,st7735r"
> -- dc-gpios: Display data/command selection (D/CX)
> -- reset-gpios: Reset signal (RSTX)
> -
> -The node for this driver must be a child node of a SPI controller, hence
> -all mandatory properties described in ../spi/spi-bus.txt must be specified.
> -
> -Optional properties:
> -- rotation: panel rotation in degrees counter clockwise (0,90,180,270)
> -- backlight: phandle of the backlight device attached to the panel
> -
> -Example:
> -
> - backlight: backlight {
> - compatible = "gpio-backlight";
> - gpios = <&gpio 44 GPIO_ACTIVE_HIGH>;
> - };
> -
> - ...
> -
> - display@0{
> - compatible = "jianda,jd-t18003-t01", "sitronix,st7735r";
> - reg = <0>;
> - spi-max-frequency = <32000000>;
> - dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>;
> - reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>;
> - rotation = <270>;
> - backlight = &backlight;
> - };
> diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> new file mode 100644
> index 0000000000000000..21bccc91f74255e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/sitronix,st7735r.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sitronix ST7735R Display Panels Device Tree Bindings
> +
> +maintainers:
> + - David Lechner <david@...hnology.com>
> +
> +description:
> + This binding is for display panels using a Sitronix ST7735R controller in
> + SPI mode.
> +
> +allOf:
> + - $ref: panel/panel-common.yaml#
not all of these properties are applicable.
> +
> +properties:
> + compatible:
> + oneOf:
> + - description:
> + Adafruit 1.8" 160x128 Color TFT LCD (Product ID 358 or 618)
> + items:
> + - enum:
> + - jianda,jd-t18003-t01
> + - const: sitronix,st7735r
> +
> + spi-max-frequency:
> + maximum: 32000000
> +
> + dc-gpios:
> + maxItems: 1
> + description: Display data/command selection (D/CX)
> +
> +required:
> + - compatible
> + - reg
> + - dc-gpios
> + - reset-gpios
Missing optional rotation and backlight properties.
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + backlight: backlight {
> + compatible = "gpio-backlight";
> + gpios = <&gpio 44 GPIO_ACTIVE_HIGH>;
> + };
> +
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + display@0{
> + compatible = "jianda,jd-t18003-t01", "sitronix,st7735r";
> + reg = <0>;
> + spi-max-frequency = <32000000>;
> + dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>;
> + rotation = <270>;
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ea8262509bdd21ac..3007f83bd504194a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5382,7 +5382,7 @@ M: David Lechner <david@...hnology.com>
> T: git git://anongit.freedesktop.org/drm/drm-misc
> S: Maintained
> F: drivers/gpu/drm/tiny/st7735r.c
> -F: Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> +F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
>
> DRM DRIVER FOR SONY ACX424AKP PANELS
> M: Linus Walleij <linus.walleij@...aro.org>
>
Powered by blists - more mailing lists