linux-kernel - RE: [PATCH resend] scsi: smartpqi: add missed free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN6PR11MB276708CE42A1B7B8FF6BDB74E1320@SN6PR11MB2767.namprd11.prod.outlook.com>
Date:   Mon, 20 Jan 2020 16:24:17 +0000
From:   <Don.Brace@...rochip.com>
To:     <hslester96@...il.com>
CC:     <don.brace@...rosemi.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <esc.storagedev@...rosemi.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH resend] scsi: smartpqi: add missed free_irq in suspend

-----Original Message-----

The driver calls request_irq in resume but does not call free_irq in suspend.
Add the missed call to fix it.

Signed-off-by: Chuhong Yuan <hslester96@...il.com>

NAK: free_irq is called in pqi_resume after checking for correct power state change. (in pqi_free_interrupts())

Thanks for your review,
Don


---
 drivers/scsi/smartpqi/smartpqi_init.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 7b7ef3acb504..2251c39afb1b 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -8078,6 +8078,8 @@ static __maybe_unused int pqi_suspend(struct pci_dev *pci_dev, pm_message_t stat
        pqi_ctrl_wait_for_pending_io(ctrl_info, NO_TIMEOUT);
        pqi_stop_heartbeat_timer(ctrl_info);

+       free_irq(pci_irq_vector(pci_dev, 0), 
+ &ctrl_info->queue_groups[0]);
+
        if (state.event == PM_EVENT_FREEZE)
                return 0;

--
2.24.0