linux-kernel - Re: [PATCH 5/5] input: joystick: Add ADC attached joystick driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200120193902.GH47797@dtor-ws>
Date:   Mon, 20 Jan 2020 11:39:02 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Jonathan Cameron <jic23@...23.retrosnub.co.uk>
Cc:     Artur Rojek <contact@...ur-rojek.eu>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Paul Cercueil <paul@...pouillou.net>,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] input: joystick: Add ADC attached joystick driver.

On Sat, Jan 11, 2020 at 11:54:40AM +0000, Jonathan Cameron wrote:
> On Sun,  5 Jan 2020 01:16:39 +0100
> Artur Rojek <contact@...ur-rojek.eu> wrote:
> 
> > Add a driver for joystick devices connected to ADC controllers
> > supporting the Industrial I/O subsystem.
> > 
> > Signed-off-by: Artur Rojek <contact@...ur-rojek.eu>
> > Tested-by: Paul Cercueil <paul@...pouillou.net>
> 
> Looks pretty good, but I'd like to see a little more sanity checking
> on probe that the channels are in a format this driver can actually
> handle.  Given we can check channel size and consistency etc early
> it would be better to fail to probe than just report error data later.

Artur,

>From my POV it looks decent so as soon as you address Jonathan requests
you can add

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

assuming you want it to be perged through IIO tree.

Thanks.

-- 
Dmitry