lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jan 2020 12:49:13 -0800 From: "Asutosh Das (asd)" <asutoshd@...eaurora.org> To: Stanley Chu <stanley.chu@...iatek.com>, linux-scsi@...r.kernel.org, martin.petersen@...cle.com, avri.altman@....com, alim.akhtar@...sung.com, jejb@...ux.ibm.com Cc: beanhuo@...ron.com, cang@...eaurora.org, matthias.bgg@...il.com, bvanassche@....org, linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, kuohong.wang@...iatek.com, peter.wang@...iatek.com, chun-hung.wu@...iatek.com, andy.teng@...iatek.com Subject: Re: [PATCH v1 2/3] scsi: ufs: export some functions for vendor usage On 1/16/2020 7:51 PM, Stanley Chu wrote: > Export below functions for vendor usage, > > int ufshcd_hba_enable(struct ufs_hba *hba); > int ufshcd_make_hba_operational(struct ufs_hba *hba); > int ufshcd_uic_hibern8_exit(struct ufs_hba *hba); > > Signed-off-by: Stanley Chu <stanley.chu@...iatek.com> > --- LGTM. Reviewed-by: Asutosh Das <asutoshd@...eaurora.org> > drivers/scsi/ufs/ufshcd.c | 11 +++++++---- > drivers/scsi/ufs/ufshcd.h | 3 +++ > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index bea036ab189a..1168baf358ea 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -250,7 +250,6 @@ static int ufshcd_probe_hba(struct ufs_hba *hba); > static int __ufshcd_setup_clocks(struct ufs_hba *hba, bool on, > bool skip_ref_clk); > static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on); > -static int ufshcd_uic_hibern8_exit(struct ufs_hba *hba); > static int ufshcd_uic_hibern8_enter(struct ufs_hba *hba); > static inline void ufshcd_add_delay_before_dme_cmd(struct ufs_hba *hba); > static int ufshcd_host_reset_and_restore(struct ufs_hba *hba); > @@ -3865,7 +3864,7 @@ static int ufshcd_uic_hibern8_enter(struct ufs_hba *hba) > return ret; > } > > -static int ufshcd_uic_hibern8_exit(struct ufs_hba *hba) > +int ufshcd_uic_hibern8_exit(struct ufs_hba *hba) > { > struct uic_command uic_cmd = {0}; > int ret; > @@ -3891,6 +3890,7 @@ static int ufshcd_uic_hibern8_exit(struct ufs_hba *hba) > > return ret; > } > +EXPORT_SYMBOL_GPL(ufshcd_uic_hibern8_exit); > > void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit) > { > @@ -4162,7 +4162,7 @@ static int ufshcd_complete_dev_init(struct ufs_hba *hba) > * > * Returns 0 on success, non-zero value on failure > */ > -static int ufshcd_make_hba_operational(struct ufs_hba *hba) > +int ufshcd_make_hba_operational(struct ufs_hba *hba) > { > int err = 0; > u32 reg; > @@ -4208,6 +4208,7 @@ static int ufshcd_make_hba_operational(struct ufs_hba *hba) > out: > return err; > } > +EXPORT_SYMBOL_GPL(ufshcd_make_hba_operational); > > /** > * ufshcd_hba_stop - Send controller to reset state > @@ -4285,7 +4286,7 @@ static int ufshcd_hba_execute_hce(struct ufs_hba *hba) > return 0; > } > > -static int ufshcd_hba_enable(struct ufs_hba *hba) > +int ufshcd_hba_enable(struct ufs_hba *hba) > { > int ret; > > @@ -4310,6 +4311,8 @@ static int ufshcd_hba_enable(struct ufs_hba *hba) > > return ret; > } > +EXPORT_SYMBOL_GPL(ufshcd_hba_enable); > + > static int ufshcd_disable_tx_lcc(struct ufs_hba *hba, bool peer) > { > int tx_lanes, i, err = 0; > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index b1a1c65be8b1..fca372d98495 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -799,8 +799,11 @@ static inline void ufshcd_rmwl(struct ufs_hba *hba, u32 mask, u32 val, u32 reg) > > int ufshcd_alloc_host(struct device *, struct ufs_hba **); > void ufshcd_dealloc_host(struct ufs_hba *); > +int ufshcd_hba_enable(struct ufs_hba *hba); > int ufshcd_init(struct ufs_hba * , void __iomem * , unsigned int); > +int ufshcd_make_hba_operational(struct ufs_hba *hba); > void ufshcd_remove(struct ufs_hba *); > +int ufshcd_uic_hibern8_exit(struct ufs_hba *hba); > int ufshcd_wait_for_register(struct ufs_hba *hba, u32 reg, u32 mask, > u32 val, unsigned long interval_us, > unsigned long timeout_ms, bool can_sleep); > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project
Powered by blists - more mailing lists