linux-kernel - Re: [resend v1 1/5] block/genhd: Notify udev about capacity change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1a36b7163c10fd6c9450ba631f26b9ce23dc3f7.camel@amazon.com>
Date:   Tue, 21 Jan 2020 19:57:18 +0000
From:   "Singh, Balbir" <sblbir@...zon.com>
To:     "hch@....de" <hch@....de>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "Sangaraju, Someswarudu" <ssomesh@...zon.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "mst@...hat.com" <mst@...hat.com>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "Chaitanya.Kulkarni@....com" <Chaitanya.Kulkarni@....com>
Subject: Re: [resend v1 1/5] block/genhd: Notify udev about capacity change

On Wed, 2020-01-08 at 16:04 +0100, hch@....de wrote:
> On Tue, Jan 07, 2020 at 10:15:34PM -0500, Martin K. Petersen wrote:
> > 
> > Balbir,
> > 
> > > I did this to avoid having to enforce that set_capacity() implied a
> > > notification. Largely to control the impact of the change by default.
> > 
> > What I thought. I'm OK with set_capacity_and_notify(), btw.
> 
> To some extent it might make sense to always notify from set_capacity
> and have a set_capacity_nonotify if we don't want to notify, as in
> general we probably should notify unless we have a good reason not to.

I am not sure if this is the right path, since with the new interface, we'll
now have revalidate disk bits built into the function (see the comments from
Bob earlier). I'd be happier converting interfaces a few at a time, A quick
grep found over 100 references and I am not even sure how many of them are
resizable without hotplug in/out on the fly. Hence, I limited myself to the
small subset, I could consider expanding it later based on the need and their
ability to resize on the fly

Balbir Singh.