linux-kernel - Re: [PATCH] bpf: btf: Always output invariant hit in pahole DWARF to BTF transform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZ5wR_jTEbwYVU-z3ZBP+06p9ZTOeF_DNxqe_nQW493CA@mail.gmail.com>
Date:   Tue, 21 Jan 2020 13:46:18 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Chris Down <chris@...isdown.name>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Andrii Nakryiko <andriin@...com>,
        John Fastabend <john.fastabend@...il.com>,
        open list <linux-kernel@...r.kernel.org>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH] bpf: btf: Always output invariant hit in pahole DWARF to
 BTF transform

On Tue, Jan 21, 2020 at 12:29 PM Chris Down <chris@...isdown.name> wrote:
>
> Andrii Nakryiko writes:
> >> --- a/scripts/link-vmlinux.sh
> >> +++ b/scripts/link-vmlinux.sh
> >> @@ -108,13 +108,15 @@ gen_btf()
> >>         local bin_arch
> >>
> >>         if ! [ -x "$(command -v ${PAHOLE})" ]; then
> >> -               info "BTF" "${1}: pahole (${PAHOLE}) is not available"
> >> +               printf 'BTF: %s: pahole (%s) is not available\n' \
> >> +                       "${1}" "${PAHOLE}" >&2
> >
> >any reason not to use echo instead of printf? would be more minimal change
>
> I generally avoid using echo because it has a bunch of portability gotchas
> which printf mostly doesn't have. If you'd prefer echo, that's fine though,
> just let me know and I can send v2.

The rest of the script is using echo for errors, so let's stick to it
for consistency. Thanks!