linux-kernel - Re: [PATCH v2 1/3] alarmtimer: Make alarmtimer platform device child of RTC device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jan 2020 14:44:30 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     John Stultz <john.stultz@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, Stephen Boyd <sboyd@...nel.org>,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH v2 1/3] alarmtimer: Make alarmtimer platform device child of RTC device

Quoting Stephen Boyd (2020-01-21 11:48:09)
> @@ -115,10 +118,14 @@ static int alarmtimer_rtc_add_device(struct device *dev,
>                 get_device(dev);
>                 ws = __ws;
>                 __ws = NULL;
> +               pdev = NULL;
> +       } else {
> +               ret = - 1;

                         ^
Ick. This has an extra space.

>         }
>  unlock:
>         spin_unlock_irqrestore(&rtcdev_lock, flags);
>  
> +       platform_device_unregister(pdev);
>         wakeup_source_unregister(__ws);
>  
>         return ret;