linux-kernel - [PATCH -next] tee: amdtee: fix return value check in amdtee_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 21 Jan 2020 09:38:12 +0800
From:   Chen Zhou <chenzhou10@...wei.com>
To:     <jens.wiklander@...aro.org>
CC:     <gary.hook@....com>, <Devaraj.Rangasamy@....com>,
        <Rijo-john.Thomas@....com>, <herbert@...dor.apana.org.au>,
        <tee-dev@...ts.linaro.org>, <linux-kernel@...r.kernel.org>,
        <chenzhou10@...wei.com>
Subject: [PATCH -next] tee: amdtee: fix return value check in amdtee_driver_init

Allocation function kzalloc returns NULL not ERR_PTR on failure.
Replace IS_ERR with NULL check.

Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
---
 drivers/tee/amdtee/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
index be8937e..6370bb5 100644
--- a/drivers/tee/amdtee/core.c
+++ b/drivers/tee/amdtee/core.c
@@ -446,11 +446,11 @@ static int __init amdtee_driver_init(void)
 	}
 
 	drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
-	if (IS_ERR(drv_data))
+	if (!drv_data)
 		return -ENOMEM;
 
 	amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL);
-	if (IS_ERR(amdtee)) {
+	if (!amdtee) {
 		rc = -ENOMEM;
 		goto err_kfree_drv_data;
 	}
-- 
2.7.4