linux-kernel - Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c223c347-4c19-176f-4626-b096c12c0558@cogentembedded.com>
Date:   Tue, 21 Jan 2020 12:01:45 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Chen Zhou <chenzhou10@...wei.com>, davem@...emloft.net,
        mhabets@...arflare.com, kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0

On 21.01.2020 11:54, Chen Zhou wrote:

>>> Fixes coccicheck warning:
>>>
>>> ./drivers/net/ethernet/amd/declance.c:611:14-15:
>>>      WARNING comparing pointer to 0
>>>
>>> Compare pointer-typed values to NULL rather than 0.
>>
>>     I don't see NULL in the patch -- you used ! instead.
> 
> Yeah, i used ! here.

    Make the patch description match the diff, please.

> Thanks,
> Chen Zhou

MBR, Sergei