linux-kernel - Re: [PATCH] tcp_bbr: improve arithmetic division in bbr_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200121.104635.663739014554850228.davem@davemloft.net>
Date:   Tue, 21 Jan 2020 10:46:35 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     wenyang@...ux.alibaba.com
Cc:     edumazet@...gle.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tcp_bbr: improve arithmetic division in bbr_update_bw()

From: Wen Yang <wenyang@...ux.alibaba.com>
Date: Mon, 20 Jan 2020 18:04:56 +0800

> do_div() does a 64-by-32 division. Use div64_long() instead of it
> if the divisor is long, to avoid truncation to 32-bit.
> And as a nice side effect also cleans up the function a bit.
> 
> Signed-off-by: Wen Yang <wenyang@...ux.alibaba.com>

Applied, thank you.