linux-kernel - Re: [PATCH] pcmcia/cm4000: remove useless variable tmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2u5maFAB_tFX+3BdZFgPFqdKhDPNAuQrsjfVc3wzSYdg@mail.gmail.com>
Date:   Tue, 21 Jan 2020 11:13:49 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     Harald Welte <laforge@...monks.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pcmcia/cm4000: remove useless variable tmp

On Tue, Jan 21, 2020 at 10:55 AM Alex Shi <alex.shi@...ux.alibaba.com> wrote:

>
> From 9e54770c6911ae7da7d2f74774bbef019e459bc9 Mon Sep 17 00:00:00 2001
> From: Alex Shi <alex.shi@...ux.alibaba.com>
> Date: Fri, 17 Jan 2020 09:10:47 +0800
> Subject: [PATCH v2] pcmcia/cm4000: remove useless variable tmp
>
> No one care the value of 'tmp' in func cmm_write. better to remove it.
>
> Arnd Bergmann pointed just remove may cause warning in some arch where
> inb is macro, and suggest add a cast '(void)' for this. Thanks!
>
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Harald Welte <laforge@...monks.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-kernel@...r.kernel.org

Acked-by: Arnd Bergmann <arnd@...db.de>