linux-kernel - Re: [PATCH] fs/gfs2: remove IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHpGcMJ6DazJ_rMPB2uUKfH-1oxVy=RoLvt2nMEvcdWWCnWjDw@mail.gmail.com>
Date:   Tue, 21 Jan 2020 11:23:35 +0100
From:   Andreas Grünbacher <andreas.gruenbacher@...il.com>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     Bob Peterson <rpeterso@...hat.com>,
        Andreas Gruenbacher <agruenba@...hat.com>,
        cluster-devel <cluster-devel@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/gfs2: remove IS_DINODE

Alex,

Am Di., 21. Jan. 2020 um 09:50 Uhr schrieb Alex Shi
<alex.shi@...ux.alibaba.com>:
> After commit 1579343a73e3 ("GFS2: Remove dirent_first() function"), this
> macro isn't used any more. so remove it.
>
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Bob Peterson <rpeterso@...hat.com>
> Cc: Andreas Gruenbacher <agruenba@...hat.com>
> Cc: cluster-devel@...hat.com
> Cc: linux-kernel@...r.kernel.org
> ---
>  fs/gfs2/dir.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
> index eb9c0578978f..636a8d0f3dab 100644
> --- a/fs/gfs2/dir.c
> +++ b/fs/gfs2/dir.c
> @@ -74,7 +74,6 @@
>  #include "util.h"
>
>  #define IS_LEAF     1 /* Hashed (leaf) directory */
> -#define IS_DINODE   2 /* Linear (stuffed dinode block) directory */

The same is true for the IS_LEAF macro. I'm adjusting the patch accordingly.

The other patch removing the LBIT macros looks good as well, so I'm
applying both.

Thanks,
Andreas