linux-kernel - Re: [PATCH] proc: remove unused macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df87277c-31ff-c399-9819-0a237697efc4@redhat.com>
Date:   Tue, 21 Jan 2020 11:28:36 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     Alexey Dobriyan <adobriyan@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Pankaj gupta <pagupta@...hat.com>,
        Konstantin Khlebnikov <koct9i@...il.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] proc: remove unused macro

On 21.01.20 11:25, Alex Shi wrote:
> KPMBITS is never used from it was introduced. better to remove it.

I suggest

"fs/proc/page.c: remove unused macro KPMBITS

KPMBITS was never used since it was introduced in commit 3c3fc71c8cfa
("mm: introduce idle page tracking"). Let's remove it.
"

Reviewed-by: David Hildenbrand <david@...hat.com>

> 
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Alexey Dobriyan <adobriyan@...il.com> 
> Cc: Andrew Morton <akpm@...ux-foundation.org> 
> Cc: David Hildenbrand <david@...hat.com> 
> Cc: "Michael S. Tsirkin" <mst@...hat.com> 
> Cc: Pankaj gupta <pagupta@...hat.com> 
> Cc: Konstantin Khlebnikov <koct9i@...il.com> 
> Cc: linux-kernel@...r.kernel.org 
> Cc: linux-fsdevel@...r.kernel.org 
> ---
>  fs/proc/page.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/proc/page.c b/fs/proc/page.c
> index 7c952ee732e6..c4b1005a82bc 100644
> --- a/fs/proc/page.c
> +++ b/fs/proc/page.c
> @@ -19,7 +19,6 @@
>  
>  #define KPMSIZE sizeof(u64)
>  #define KPMMASK (KPMSIZE - 1)
> -#define KPMBITS (KPMSIZE * BITS_PER_BYTE)
>  
>  /* /proc/kpagecount - an array exposing page counts
>   *
> 


-- 
Thanks,

David / dhildenb