linux-kernel - Re: [PATCH] mmc: sdhci-cadence: remove unneeded 'inline' marker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jan 2020 13:11:04 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-mmc@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci-cadence: remove unneeded 'inline' marker

On 21/01/20 12:58 pm, Masahiro Yamada wrote:
> 'static inline' in .c files does not make much sense because
> functions may or may not be inlined irrespective of the 'inline'
> marker. It is just a hint.
> 
> This function is quite small, so very likely to be inlined by the
> compiler's optimization (-O2 or -Os), but it is up to the compiler
> after all.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
> 
>  drivers/mmc/host/sdhci-cadence.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
> index ae0ec27dd7cc..5827d3751b81 100644
> --- a/drivers/mmc/host/sdhci-cadence.c
> +++ b/drivers/mmc/host/sdhci-cadence.c
> @@ -158,7 +158,7 @@ static int sdhci_cdns_phy_init(struct sdhci_cdns_priv *priv)
>  	return 0;
>  }
>  
> -static inline void *sdhci_cdns_priv(struct sdhci_host *host)
> +static void *sdhci_cdns_priv(struct sdhci_host *host)
>  {
>  	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>  
>