linux-kernel - RE: [PATCH -next] dmaengine: fsl-qdma: fix duplicated argument to &&

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB44314C51FA4C397F352C14C8ED0D0@VI1PR04MB4431.eurprd04.prod.outlook.com>
Date:   Tue, 21 Jan 2020 02:54:54 +0000
From:   Peng Ma <peng.ma@....com>
To:     Chen Zhou <chenzhou10@...wei.com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "vkoul@...nel.org" <vkoul@...nel.org>
CC:     "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] dmaengine: fsl-qdma: fix duplicated argument to &&



>-----Original Message-----
>From: Chen Zhou <chenzhou10@...wei.com>
>Sent: 2020年1月20日 20:59
>To: dan.j.williams@...el.com; vkoul@...nel.org
>Cc: Peng Ma <peng.ma@....com>; Wen He <wen.he_1@....com>;
>jiaheng.fan@....com; dmaengine@...r.kernel.org;
>linux-kernel@...r.kernel.org; chenzhou10@...wei.com
>Subject: [PATCH -next] dmaengine: fsl-qdma: fix duplicated argument to &&
>
>There is duplicated argument to && in function fsl_qdma_free_chan_resources,
>which looks like a typo, pointer fsl_queue->desc_pool also needs NULL check,
>fix it.
>Detected with coccinelle.
>
What does the " coccinelle " mean here?

>Fixes: b092529e0aa0 ("dmaengine: fsl-qdma: Add qDMA controller driver for
>Layerscape SoCs")
>Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
>---
> drivers/dma/fsl-qdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index
>8979208..95cc025 100644
>--- a/drivers/dma/fsl-qdma.c
>+++ b/drivers/dma/fsl-qdma.c
>@@ -304,7 +304,7 @@ static void fsl_qdma_free_chan_resources(struct
>dma_chan *chan)
>
> 	vchan_dma_desc_free_list(&fsl_chan->vchan, &head);
>
>-	if (!fsl_queue->comp_pool && !fsl_queue->comp_pool)
>+	if (!fsl_queue->comp_pool && !fsl_queue->desc_pool)
> 		return;
>
Hi Chen,

Thanks very much for your patch, It is really need to check comp_pool and desc_pool here.
Reviewed-by: Peng Ma <peng.ma@....com>
Tested-by: Peng Ma <peng.ma@....com>

BR,
Peng
> 	list_for_each_entry_safe(comp_temp, _comp_temp,
>--
>2.7.4