lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jan 2020 19:09:26 -0800 From: Dan Williams <dan.j.williams@...el.com> To: "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com> Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Dave Hansen <dave.hansen@...ux.intel.com>, Christoph Hellwig <hch@....de>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-nvdimm <linux-nvdimm@...ts.01.org>, X86 ML <x86@...nel.org> Subject: Re: [PATCH v3 2/6] mm/numa: Skip NUMA_NO_NODE and online nodes in numa_map_to_online_node() On Mon, Jan 20, 2020 at 5:36 PM Aneesh Kumar K.V <aneesh.kumar@...ux.ibm.com> wrote: > > Dan Williams <dan.j.williams@...el.com> writes: > > > Update numa_map_to_online_node() to stop falling back to numa node 0 > > when the input is NUMA_NO_NODE. Also, skip the lookup if @node is > > online. This makes the routine compatible with other arch node mapping > > routines. > > > > Reported-by: Aneesh Kumar K.V <aneesh.kumar@...ux.ibm.com> > > Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@...ux.ibm.com> > > Link: https://lore.kernel.org/r/157401275716.43284.13185549705765009174.stgit@dwillia2-desk3.amr.corp.intel.com > > Signed-off-by: Dan Williams <dan.j.williams@...el.com> > > --- > > mm/mempolicy.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > index 4cff069279f6..30d76db718bf 100644 > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -137,8 +137,8 @@ int numa_map_to_online_node(int node) > > { > > int min_node; > > > > - if (node == NUMA_NO_NODE) > > - node = 0; > > + if (node == NUMA_NO_NODE || node_online(node)) > > + return node; > > > > min_node = node; > > if (!node_online(node)) { > > > The above if condition will always be true? No, not for the node_offline case, and that's typically what callers are passing. > > -aneesh
Powered by blists - more mailing lists