lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Jan 2020 13:22:10 +0100 From: Martin Schiller <ms@....tdt.de> To: David Miller <davem@...emloft.net> Cc: kubakici@...pl, khc@...waw.pl, linux-x25@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 1/2] wan/hdlc_x25: make lapb params configurable On 2020-01-21 12:01, David Miller wrote: > From: David Miller <davem@...emloft.net> > Date: Tue, 21 Jan 2020 11:41:52 +0100 (CET) > >> From: Martin Schiller <ms@....tdt.de> >> Date: Tue, 21 Jan 2020 07:00:33 +0100 >> >>> This enables you to configure mode (DTE/DCE), Modulo, Window, T1, T2, >>> N2 via >>> sethdlc (which needs to be patched as well). >>> >>> Signed-off-by: Martin Schiller <ms@....tdt.de> >> >> Applied to net-next. > > I seriously wonder how much you tested this code, because the compiler > warned > me about: > > diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c > index 63c9aeed9a34..c84536b03aa8 100644 > --- a/drivers/net/wan/hdlc_x25.c > +++ b/drivers/net/wan/hdlc_x25.c > @@ -253,7 +253,7 @@ static int x25_ioctl(struct net_device *dev, > struct ifreq *ifr) > return -EBUSY; > > /* backward compatibility */ > - if (ifr->ifr_settings.size = 0) { > + if (ifr->ifr_settings.size == 0) { > new_settings.dce = 0; > new_settings.modulo = 8; > new_settings.window = 7; > > I'll commit that fix, but this is truly careless especially since the > compiler > warns about it. I really want to apologize for that. I am currently working with several branches of different kernel versions (mainly 4.19) and I have overlooked this error when porting the latest changes.
Powered by blists - more mailing lists