linux-kernel - Re: [PATCH] sparc32: fix struct ipc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200121.132725.1938964059289099578.davem@davemloft.net>
Date:   Tue, 21 Jan 2020 13:27:25 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     sam@...nborg.org, stable@...r.kernel.org, ldv@...linux.org,
        dalias@...c.org, libc-alpha@...rceware.org,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparc32: fix struct ipc64_perm type definition

From: Arnd Bergmann <arnd@...db.de>
Date: Tue, 14 Jan 2020 14:26:14 +0100

> As discussed in the strace issue tracker, it appears that the sparc32
> sysvipc support has been broken for the past 11 years. It was however
> working in compat mode, which is how it must have escaped most of the
> regular testing.
> 
> The problem is that a cleanup patch inadvertently changed the uid/gid
> fields in struct ipc64_perm from 32-bit types to 16-bit types in uapi
> headers.
> 
> Both glibc and uclibc-ng still use the original types, so they should
> work fine with compat mode, but not natively.  Change the definitions
> to use __kernel_uid32_t and __kernel_gid32_t again.
> 
> Fixes: 83c86984bff2 ("sparc: unify ipcbuf.h")
> Link: https://github.com/strace/strace/issues/116
> Cc: <stable@...r.kernel.org> # v2.6.29
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: "Dmitry V . Levin" <ldv@...linux.org>
> Cc: Rich Felker <dalias@...c.org>
> Cc: libc-alpha@...rceware.org
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied and queued up for -stable, thanks Arnd.