linux-kernel - Re: [PATCH 0/3] KVM: Clean up guest/host cache read/write code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50f1d58a-5ac8-be1f-9c31-a49e699f362b@redhat.com>
Date:   Tue, 21 Jan 2020 14:51:47 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jim Mattson <jmattson@...gle.com>,
        Andrew Honig <ahonig@...gle.com>,
        Barret Rhoden <brho@...gle.com>
Subject: Re: [PATCH 0/3] KVM: Clean up guest/host cache read/write code

On 10/01/20 00:56, Sean Christopherson wrote:
> Minor cleanup to fix the underlying crustiness that led to an uninitialized
> variable warning reported by Barret.
> 
> The first two patches are tagged with Fixes:, but I don't know that they're
> actually worth backporting to stable.  Functionally, everthing works, it's
> just a bit weird and AFAICT not what is intended.  It might be preferable
> to take Barret's patch[*] first and only mark that for stable, as it fixes
> the immediate issue without revamping __kvm_gfn_to_hva_cache_init().
> 
> [*] https://lkml.kernel.org/r/20200109195855.17353-1-brho@google.com
> 
> Sean Christopherson (3):
>   KVM: Check for a bad hva before dropping into the ghc slow path
>   KVM: Clean up __kvm_gfn_to_hva_cache_init() and its callers
>   KVM: Return immediately if __kvm_gfn_to_hva_cache_init() fails
> 
>  virt/kvm/kvm_main.c | 45 ++++++++++++++++++++++++++-------------------
>  1 file changed, 26 insertions(+), 19 deletions(-)
> 

Queued, thanks.

Paolo