linux-kernel - Re: [PATCH] drivers: optee: Fix compilation issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fa0e5b3-6e88-3fa2-9e16-046350cc752b@arm.com>
Date:   Tue, 21 Jan 2020 14:23:02 +0000
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     jens.wiklander@...aro.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     tee-dev@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: optee: Fix compilation issue.

Hi Greg,

I sent the fix below few days ago to the optee maintaners but I did not get any
answer. Could you please pick it up?

On 10/01/2020 12:28, Vincenzo Frascino wrote:
> The optee driver uses specific page table types to verify if a memory
> region is normal. These types are not defined in nommu systems. Trying
> to compile the driver in these systems results in a build error:
> 
>   linux/drivers/tee/optee/call.c: In function ‘is_normal_memory’:
>   linux/drivers/tee/optee/call.c:533:26: error: ‘L_PTE_MT_MASK’ undeclared
>      (first use in this function); did you mean ‘PREEMPT_MASK’?
>      return (pgprot_val(p) & L_PTE_MT_MASK) == L_PTE_MT_WRITEALLOC;
>                              ^~~~~~~~~~~~~
>                              PREEMPT_MASK
>   linux/drivers/tee/optee/call.c:533:26: note: each undeclared identifier is
>      reported only once for each function it appears in
>   linux/drivers/tee/optee/call.c:533:44: error: ‘L_PTE_MT_WRITEALLOC’ undeclared
>      (first use in this function)
>      return (pgprot_val(p) & L_PTE_MT_MASK) == L_PTE_MT_WRITEALLOC;
>                                             ^~~~~~~~~~~~~~~~~~~
> 
> Make the optee driver depend on MMU to fix the compilation issue.
> 
> Cc: Jens Wiklander <jens.wiklander@...aro.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> ---
>  drivers/tee/optee/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig
> index d1ad512e1708..3ca71e3812ed 100644
> --- a/drivers/tee/optee/Kconfig
> +++ b/drivers/tee/optee/Kconfig
> @@ -3,6 +3,7 @@
>  config OPTEE
>  	tristate "OP-TEE"
>  	depends on HAVE_ARM_SMCCC
> +	depends on MMU
>  	help
>  	  This implements the OP-TEE Trusted Execution Environment (TEE)
>  	  driver.
> 

-- 
Regards,
Vincenzo

Download attachment "pEpkey.asc" of type "application/pgp-keys" (14072 bytes)