linux-kernel - Re: [PATCH v2 2/4] x86/xen: add basic KASAN support for PV kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202001220012.aV6Aue8k%lkp@intel.com>
Date:   Wed, 22 Jan 2020 00:25:16 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sergey Dyasli <sergey.dyasli@...rix.com>
Cc:     kbuild-all@...ts.01.org, xen-devel@...ts.xen.org,
        kasan-dev@...glegroups.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        George Dunlap <george.dunlap@...rix.com>,
        Ross Lagerwall <ross.lagerwall@...rix.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Sergey Dyasli <sergey.dyasli@...rix.com>
Subject: Re: [PATCH v2 2/4] x86/xen: add basic KASAN support for PV kernel

Hi Sergey,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on xen-tip/linux-next]
[also build test ERROR on tip/x86/mm tip/auto-latest linux/master linus/master v5.5-rc7 next-20200121]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Sergey-Dyasli/basic-KASAN-support-for-Xen-PV-domains/20200118-073544
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: x86_64-randconfig-a002-20200121 (attached as .config)
compiler: gcc-6 (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/x86/xen/mmu_pv.c: In function 'xen_pv_kasan_early_init':
>> arch/x86/xen/mmu_pv.c:1778:16: error: 'kasan_early_shadow_pud' undeclared (first use in this function)
     set_page_prot(kasan_early_shadow_pud, PAGE_KERNEL_RO);
                   ^~~~~~~~~~~~~~~~~~~~~~
   arch/x86/xen/mmu_pv.c:1778:16: note: each undeclared identifier is reported only once for each function it appears in
>> arch/x86/xen/mmu_pv.c:1779:16: error: 'kasan_early_shadow_pmd' undeclared (first use in this function)
     set_page_prot(kasan_early_shadow_pmd, PAGE_KERNEL_RO);
                   ^~~~~~~~~~~~~~~~~~~~~~
>> arch/x86/xen/mmu_pv.c:1780:16: error: 'kasan_early_shadow_pte' undeclared (first use in this function)
     set_page_prot(kasan_early_shadow_pte, PAGE_KERNEL_RO);
                   ^~~~~~~~~~~~~~~~~~~~~~

vim +/kasan_early_shadow_pud +1778 arch/x86/xen/mmu_pv.c

  1774	
  1775	pgd_t * __init xen_pv_kasan_early_init(void)
  1776	{
  1777		/* PV page tables must be read-only */
> 1778		set_page_prot(kasan_early_shadow_pud, PAGE_KERNEL_RO);
> 1779		set_page_prot(kasan_early_shadow_pmd, PAGE_KERNEL_RO);
> 1780		set_page_prot(kasan_early_shadow_pte, PAGE_KERNEL_RO);
  1781	
  1782		/* Return a pointer to the initial PV page tables */
  1783		return (pgd_t *)xen_start_info->pt_base;
  1784	}
  1785	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (31776 bytes)