linux-kernel - Re: [PATCH] serial: 8250_tegra: Create Tegra specific 8250 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f02faa4c-5838-15d2-1b76-75c17fcc0d9d@gmail.com>
Date:   Tue, 21 Jan 2020 19:31:35 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Jon Hunter <jonathanh@...dia.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, Jeff Brasen <jbrasen@...dia.com>
Subject: Re: [PATCH] serial: 8250_tegra: Create Tegra specific 8250 driver

Hello Jon,

20.01.2020 19:01, Jon Hunter пишет:

[snip]

> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res)
> +		return -ENODEV;
> +
> +	port->membase = devm_ioremap(&pdev->dev, res->start,
> +				     resource_size(res));

devm_platform_ioremap_resource()

> +	if (!port->membase)
> +		return -ENOMEM;
> +
> +	port->mapbase = res->start;
> +	port->mapsize = resource_size(res);
> +
> +	uart->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);

Why reset is shared? It shall not be shared at least on T20/30/124/210..

[snip]