linux-kernel - Re: [PATCH v2 05/12] tracing: Add synth_event_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200121115342.03c0fd72@gandalf.local.home>
Date:   Tue, 21 Jan 2020 11:53:42 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Tom Zanussi <zanussi@...nel.org>
Cc:     artem.bityutskiy@...ux.intel.com, mhiramat@...nel.org,
        linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [PATCH v2 05/12] tracing: Add synth_event_run_command()

On Fri, 10 Jan 2020 14:35:11 -0600
Tom Zanussi <zanussi@...nel.org> wrote:

> From: Masami Hiramatsu <mhiramat@...nel.org>
> 
> This snippet was taken from v4 of Masami's 'tracing/boot: Add
> synthetic event support' patch.
> 
> >From the original: 'The synthetic node requires "fields" string  
> arraies, which defines the fields as same as tracing/synth_events
> interface.'
> 
> synth_event_run_command() provides the means to execute the synthetic
> event create command using the synthetic event command string.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>

If you base your next series off of my for-next branch, you wont need
this patch.

-- Steve


> ---
>  kernel/trace/trace_events_hist.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 8c9894681100..0886ca6da255 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -1390,6 +1390,11 @@ static int create_or_delete_synth_event(int argc, char **argv)
>  	return ret == -ECANCELED ? -EINVAL : ret;
>  }
>  
> +int synth_event_run_command(const char *command)
> +{
> +	return trace_run_command(command, create_or_delete_synth_event);
> +}
> +
>  static int synth_event_create(int argc, const char **argv)
>  {
>  	const char *name = argv[0];