linux-kernel - Re: [PATCH v4 6/6] Documentation: ACPI: Document probe-low-power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jan 2020 18:58:28 +0200
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     linux-i2c <linux-i2c@...r.kernel.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Bingbu Cao <bingbu.cao@...el.com>, linux-media@...r.kernel.org,
        Chiranjeevi Rapolu <chiranjeevi.rapolu@...el.com>,
        Hyungwoo Yang <hyungwoo.yang@...el.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Arnd Bergmann <arnd@...db.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Mani, Rajmohan" <rajmohan.mani@...el.com>,
        Tomasz Figa <tfiga@...omium.org>
Subject: Re: [PATCH v4 6/6] Documentation: ACPI: Document probe-low-power
 _DSD property

On Tue, Jan 21, 2020 at 05:56:39PM +0100, Rafael J. Wysocki wrote:
> On Tue, Jan 21, 2020 at 5:19 PM Sakari Ailus
> <sakari.ailus@...ux.intel.com> wrote:
> >
> > On Tue, Jan 21, 2020 at 05:09:44PM +0100, Rafael J. Wysocki wrote:
> > > On Tue, Jan 21, 2020 at 2:41 PM Sakari Ailus
> > > <sakari.ailus@...ux.intel.com> wrote:
> > > >
> > > > Document the probe-low-power _DSD property and how it is used with I²C
> > > > drivers.
> > > >
> > > > Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> > > > ---
> > > >  .../acpi/dsd/probe-low-power.rst              | 28 +++++++++++++++++++
> > > >  Documentation/firmware-guide/acpi/index.rst   |  1 +
> > > >  2 files changed, 29 insertions(+)
> > > >  create mode 100644 Documentation/firmware-guide/acpi/dsd/probe-low-power.rst
> > > >
> > > > diff --git a/Documentation/firmware-guide/acpi/dsd/probe-low-power.rst b/Documentation/firmware-guide/acpi/dsd/probe-low-power.rst
> > > > new file mode 100644
> > > > index 0000000000000..e0343ffefe071
> > > > --- /dev/null
> > > > +++ b/Documentation/firmware-guide/acpi/dsd/probe-low-power.rst
> > > > @@ -0,0 +1,28 @@
> > > > +.. SPDX-License-Identifier: GPL-2.0
> > > > +
> > > > +======================================
> > > > +Probing I²C devices in low power state
> > > > +======================================
> > > > +
> > > > +Introduction
> > > > +============
> > > > +
> > > > +In some cases it may be preferred to leave certain devices powered off for
> > > > +the entire system bootup if powering on these devices has adverse side
> > > > +effects, beyond just powering on the said device. The _DSD property
> > > > +"probe-low-power" has been defined for this purpose.
> > >
> > > Well, if you say "has been defined", you need to provide a pointer to
> > > the definition document (a specification of some sort or similar).
> >
> > How about:
> >
> > s/has been defined/is used/
> 
> I would say "Linux recognizes the ... that can be used for this purpose."

Ack; I'll use this in v5.

-- 
Sakari Ailus