linux-kernel - Re: [PATCH v4 00/38] platform/x86: Rework intel_scu_ipc and intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200121172141.GB2665@lahna.fi.intel.com>
Date:   Tue, 21 Jan 2020 19:21:41 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Darren Hart <dvhart@...radead.org>,
        Lee Jones <lee.jones@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Zha Qipeng <qipeng.zha@...el.com>,
        "David E . Box" <david.e.box@...ux.intel.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 00/38] platform/x86: Rework intel_scu_ipc and
 intel_pmc_ipc drivers

On Tue, Jan 21, 2020 at 05:06:56PM +0000, Mark Brown wrote:
> On Tue, Jan 21, 2020 at 07:00:22PM +0200, Mika Westerberg wrote:
> 
> > OK, thanks for the clarification. I guess in this case we can probably
> > just live without using it, if that's fine for Lee and others. The new
> > MFD driver itself is ~500 lines so not sure how much regmap would help
> > there, and we only expose two simple functions for the subdevices both
> > dealing with 64-bit registers.
> 
> The usual motivation is all the diagnostic infrastructure you get with
> regmap - tracepoints for I/O and the ability to dump the register map in
> debugfs mainly.

Right.

Here we are talking about a "map" of two registers so probably not worth
the added trouble ;-)